Comments on: Posting Code in WordPress (and comments!)

By: Eric

Eric — Thu, 01 Jan 1970 00:00:00 +0000

great fix. why is this not integrated into Code Markup yet? hey btw do you guys know why it has started sticking rel="nofollow" into markup? it only does it in a comment. even if markup="none". kinds of defeats the purpose.

By: Rodrigo de Araujo

Rodrigo de Araujo — Thu, 01 Jan 1970 00:00:00 +0000

Congratulations! That´s nice. Well done and good looking, it´s also easy to install, but I´m still looking for some more up-to-date stats map.

I will give this widget a little more time to satisfy me. Let´s see what happens.

By: Bzeurghk

Bzeurghk — Thu, 01 Jan 1970 00:00:00 +0000

Thanks!,

By: Claire

Claire — Thu, 01 Jan 1970 00:00:00 +0000

For this fix to work with the newest version of Code Markup, the last line of your patch needs to be changed to:

add_filter('comment_text', 'tguy_cmu_tidy_code', '11');

(tguy_cmu_fix_quotes seems to have been upgraded )

By: Mike Miller

Mike Miller — Thu, 01 Jan 1970 00:00:00 +0000

Thanks. There's one remaining issue that needs to be fixed — I don't think wordpress should be allowed to insert rel="nofollow" into the href's wrapped by code. However, I can't just remove all rel="nofollow" lines, because the user may have put them there.

I'll look into it, but I'm not sure exactly how to do this.

By: Mike Miller

Mike Miller — Thu, 01 Jan 1970 00:00:00 +0000

Ok. On line 109, there's a check if ($allow == 'none' || $allow == ''). If you add the following below that, we can remove rel="nofollow" from within the

 tag. Normal links will still have rel="nofollow". 

$escapedContent = preg_replace("/(]*( |\t|\n)rel=)('|\")(([^\3]*( [^ \3]*)*) )?nofollow/", "$1$3$5", $escapedContent);
$escapedContent = preg_replace("/(]*)( |\t|\n)rel=(''|\"\")([^>]*>)/", "$1$4", $escapedContent);


The only problem with this is that if the user himself puts in rel="nofollow", it won't be kept. I'm not sure (yet) how to fix that.

These regular expressions were taken from the DoFollow plugin.



By: Bennett
Bennett — Thu, 01 Jan 1970 00:00:00 +0000
Thanks Mike! Great work. Your enhancement will be in the next version of Code Markup.



By: Mike Miller
Mike Miller — Thu, 01 Jan 1970 00:00:00 +0000
See? It works!

Regular: Link?
With allow="none": Link?